Room scanning refactor #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boulder solver needs implementation of new refactor quiz blaze and weridos needs testing
Signed-off-by: odtheking <[email protected]>
freebonsai
requested changes
Oct 25, 2024
odinmain/src/main/kotlin/me/odinmain/features/impl/dungeon/puzzlesolvers/BeamsSolver.kt
Outdated
Show resolved
Hide resolved
odinmain/src/main/kotlin/me/odinmain/features/impl/dungeon/puzzlesolvers/BoulderSolver.kt
Outdated
Show resolved
Hide resolved
odinmain/src/main/kotlin/me/odinmain/features/impl/dungeon/puzzlesolvers/IceFillSolver.kt
Outdated
Show resolved
Hide resolved
odinmain/src/main/kotlin/me/odinmain/features/impl/dungeon/puzzlesolvers/QuizSolver.kt
Outdated
Show resolved
Hide resolved
odinmain/src/main/kotlin/me/odinmain/features/impl/dungeon/puzzlesolvers/QuizSolver.kt
Outdated
Show resolved
Hide resolved
odinmain/src/main/kotlin/me/odinmain/features/impl/dungeon/puzzlesolvers/TPMazeSolver.kt
Outdated
Show resolved
Hide resolved
…m-Scanning-Refactor
Signed-off-by: odtheking <[email protected]>
# Conflicts: # src/main/kotlin/me/odinmain/features/impl/dungeon/puzzlesolvers/BeamsSolver.kt # src/main/kotlin/me/odinmain/features/impl/dungeon/puzzlesolvers/IceFillSolver.kt # src/main/kotlin/me/odinmain/features/impl/dungeon/puzzlesolvers/QuizSolver.kt # src/main/kotlin/me/odinmain/utils/skyblock/dungeon/tiles/RoomData.kt
Signed-off-by: odtheking <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i am thinking it would make more sense if the full room it self had rotation and room data
both those values are applicable for all room components
and then u would have only FullRoom data structure containing: rotation, data, claypos, waypoints, roomcomponents
and a room component data structure containing each rooms x and z and core which should be the only unique per component values
this would make it from having 3 data structures to 2
should also greatly improve syntax so u can do:
val roomName = event.fullRoom?.data.name ?: return
instead of:
val roomName = event.fullRoom?.room.data.name ?: return // <-- orb = orb.orb
Also implemented getRealCoords for PuzzleSolvers and added unique handling for fairy room